Skip to content

Add Accessibility Selected for iOS CollectionView #29014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 16 commits into from
May 7, 2025
+385 −1
Merged

Add Accessibility Selected for iOS CollectionView #29014

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f83cf65
work for iOS and Android
tj-devel709 Apr 11, 2025
5c8bc55
sample code to remove later
tj-devel709 Apr 11, 2025
ef44f49
working when changing selectionMode with iOS and android
tj-devel709 Apr 15, 2025
a6c7165
UITests
tj-devel709 Apr 15, 2025
c6218a8
Adds windows to UITest
tj-devel709 Apr 16, 2025
9686f7e
add tests for CV2
tj-devel709 Apr 16, 2025
3bd7046
screenshots 1
tj-devel709 Apr 18, 2025
58ddb16
screenshots 2
tj-devel709 Apr 18, 2025
2e5f0ed
screenshots 3
tj-devel709 Apr 21, 2025
fad0e84
screenshots 4
tj-devel709 Apr 21, 2025
76a6161
add windows delay and rename similarly named tests
tj-devel709 Apr 23, 2025
addf337
screenshots 5
tj-devel709 Apr 23, 2025
70e5518
screenshots 6
tj-devel709 Apr 24, 2025
f51ae80
screenshots 7
tj-devel709 Apr 24, 2025
5c70c02
typo in class name
tj-devel709 Apr 28, 2025
b74cb7a
removing android stuff
tj-devel709 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add windows delay and rename similarly named tests
  • Loading branch information
@tj-devel709
tj-devel709 committed Apr 23, 2025
commit 76a6161d5f46280fbdbcc5199acae1a7d192148f
16 changes: 16 additions & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21375.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ public Issue21375(TestDevice device) : base(device) { }

[Test]
[Category(UITestCategories.CollectionView)]
#if WINDOWS // Windows screenshots are a little behind at times. Adding small delays to help with that
public async Task SelectedItemsShowSelected ()
#else
public void SelectedItemsShowSelected ()
#endif
{
var collectionView = App.WaitForElement("collectionView");
var centerX = collectionView.GetRect().X + (collectionView.GetRect().Width / 2);
Expand All @@ -24,16 +28,25 @@ public void SelectedItemsShowSelected ()

App.TapCoordinates(centerX, firstItemY);
App.WaitForElement("calculateButton").Tap();
#if WINDOWS // Windows has a little bit of delay
await Task.Delay(10);
#endif
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "_single");

App.WaitForElement("multipleButton").Tap();
App.TapCoordinates(centerX, secondItemY);
App.TapCoordinates(centerX, thirdItemY);
App.WaitForElement("calculateButton").Tap();
#if WINDOWS // Windows has a little bit of delay
await Task.Delay(10);
#endif
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "_multiple");

App.WaitForElement("noneButton").Tap();
App.WaitForElement("calculateButton").Tap();
#if WINDOWS // Windows has a little bit of delay
await Task.Delay(10);
#endif
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "_none");

App.WaitForElement("singleButton").Tap();
Expand All @@ -44,6 +57,9 @@ public void SelectedItemsShowSelected ()

App.WaitForElement("multipleButton").Tap();
App.WaitForElement("calculateButton").Tap();
#if WINDOWS // Windows has a little bit of delay
await Task.Delay(10);
#endif
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "_multiple");
}
}
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21375_2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public Issue21375_2(TestDevice device) : base(device) { }

[Test]
[Category(UITestCategories.CollectionView)]
public void SelectedItemsShowSelected ()
public void SelectedItemsShowSelected2()
{
var collectionView = App.WaitForElement("collectionView");
var centerX = collectionView.GetRect().X + (collectionView.GetRect().Width / 2);
Expand Down
Loading