Skip to content

Use latest map renderer for Android Google Maps #29007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Apr 15, 2025

Description of Change

Implements a change to use the latest Google Maps renderer as suggested here: https://mapsplatform.google.com/resources/blog/learn-about-our-updated-renderer-maps-sdk-android/

Issues Fixed

Fixes #20740

@jfversluis jfversluis added platform/android p/0 Work that we can't release without area-controls-map Map / Maps labels Apr 15, 2025
@jfversluis jfversluis added this to the .NET 9 SR7 milestone Apr 15, 2025
@bcaceiro
Copy link

@jfversluis just to confirm: if we want to try this before in our apps, is this the same behaviour?

Android/MainApplication.cs

  protected override MauiApp CreateMauiApp()
  {
      MapsInitializer.Initialize(Platform.AppContext, MapsInitializer.Renderer.Latest, null);
      return MauiProgram.CreateMauiApp();
  }

@jfversluis
Copy link
Member Author

jfversluis commented Apr 16, 2025

@bcaceiro that should work! As long as you call it before the first map instance is created. You can confirm what renderer is used in the debug output (as mentioned in the linked issue). Let me know if that works as a workaround for people until this is released.

@bcaceiro
Copy link

@bcaceiro that should work! As long as you call it before the first map instance is created. You can confirm what renderer is used in the debug output (as mentioned in the linked issue). Let me know if that works as a workaround for people until this is released.

Thanks, buuut , not quite - in release mode, app is crashing on startup. Will have to investigate better though. ( using MAUI 9.0.50)

@jfversluis
Copy link
Member Author

@bcaceiro can you try the NuGets resulting from this PR? Instructions are here if you need them.

@jfversluis jfversluis marked this pull request as ready for review April 16, 2025 07:03
@jfversluis jfversluis requested a review from a team as a code owner April 16, 2025 07:03
@jfversluis jfversluis moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 16, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Apr 16, 2025
@jfversluis jfversluis requested a review from jsuarezruiz April 16, 2025 09:58
@jfversluis jfversluis moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Apr 16, 2025
@rmarinho rmarinho moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 22, 2025
@PureWeen PureWeen changed the base branch from main to inflight/current April 22, 2025 22:10
@PureWeen PureWeen merged commit b0e6b60 into inflight/current Apr 22, 2025
130 checks passed
@PureWeen PureWeen deleted the fix-20740 branch April 22, 2025 22:10
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 22, 2025
PureWeen pushed a commit that referenced this pull request Apr 23, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
anandhan-rajagopal pushed a commit to anandhan-rajagopal/maui that referenced this pull request May 2, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
anandhan-rajagopal pushed a commit to anandhan-rajagopal/maui that referenced this pull request May 2, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
PureWeen pushed a commit that referenced this pull request May 2, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
SuthiYuvaraj pushed a commit to SuthiYuvaraj/maui that referenced this pull request May 9, 2025
* Use latest map renderer for Android Google Maps

* Revert "Use latest map renderer for Android Google Maps"

This reverts commit 66494aa.

* Move use latest renderer to UseMauiMaps
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-map Map / Maps p/0 Work that we can't release without platform/android
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support for latest renderer in Google Map
5 participants