Skip to content

[Testing] Recover the uitest-build task on Android cake #28452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Recover the uitest-build task on Android cake.

We had the uitest-build task in the Android cake file

Task("uitest-build")
until recent changes 4c742b9.

This PR recover it to keep allowing to run UITests like we describe in the wiki https://github.com/dotnet/maui/wiki/UITests:

./build.ps1 -Script eng/devices/android.cake --target=uitest-build
./build.ps1 -Script eng/devices/android.cake --target=uitest-prepare

If not necessary, I should review the Wiki to update it.

@Copilot Copilot AI review requested due to automatic review settings March 17, 2025 16:12
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner March 17, 2025 16:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR recovers the "uitest-build" task in the Android cake file to allow running UITests as described in the documentation.

  • Adds a new task "uitest-build" that depends on "dotnet-buildtasks".
  • Introduces the helper method ExecuteBuildUITestApp to build the UI Test app using DotNetBuild.

@jsuarezruiz jsuarezruiz marked this pull request as draft March 17, 2025 16:24
@jsuarezruiz jsuarezruiz changed the title Recover the uitest-build task on Android cake [Testing] Recover the uitest-build task on Android cake Mar 17, 2025
@jsuarezruiz jsuarezruiz marked this pull request as ready for review March 19, 2025 15:51
Copy link
Contributor

@anandhan-rajagopal anandhan-rajagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz I have tested the current code changes which are not fully functional as expected. To get it working properly, a few additional modifications are necessary. Could you please review the changes attached below and commit them?

image

Reference:

var projectPath = Argument("project", EnvironmentVariable("IOS_TEST_PROJECT") ?? DEFAULT_IOS_PROJECT);

@anandhan-rajagopal anandhan-rajagopal self-requested a review May 6, 2025 01:37
@jfversluis jfversluis merged commit 2083350 into main Jun 17, 2025
128 checks passed
@jfversluis jfversluis deleted the fix-uitests-cake branch June 17, 2025 10:45
rmarinho pushed a commit that referenced this pull request Jun 24, 2025
* Recover the uitest-build task on Android cake

* Update android.cake

---------

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants