Skip to content

[Android][NET 10] Fix: Ensure Image consumes touches properly #28429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

[Android][NET 10] Fix: Ensure Image consumes touches properly #28429

merged 4 commits into from
Apr 23, 2025
+15 −5

Conversation

bhavanesh2001
Copy link
Contributor

@bhavanesh2001 bhavanesh2001 commented Mar 16, 2025 •
edited
Loading

Description of Change

This PR fixes issue #27227, where Image on Android was not properly intercepting touches based on its InputTransparent property.

The fix ensures that the Clickable property of the ImageView is correctly set according to the InputTransparent value

Issues Fixed

Fixes #27227

@bhavanesh2001 bhavanesh2001 requested a review from a team as a code owner March 16, 2025 02:53
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 16, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@jsuarezruiz jsuarezruiz added platform/android area-image Image loading, sources, caching area-gestures Gesture types labels Mar 17, 2025
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@bhavanesh2001
Copy link
Contributor Author

Screenshot 2025-03-18 094916

rmarinho
rmarinho requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test ValidateIsImportantForAccessibility

https://dev.azure.com/xamarin/public/_build/results?buildId=137932&view=ms.vss-test-web.build-test-results-tab&runId=3907035&resultId=100371&paneView=debug

@bhavanesh2001
Copy link
Contributor Author

Screenshot 2025-03-26 at 10 59 15 PM

@bhavanesh2001 bhavanesh2001 requested a review from rmarinho March 26, 2025 17:29
@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit a71e593 into dotnet:net10.0 Apr 23, 2025
128 checks passed
@rmarinho rmarinho added this to the .NET 10.0-preview4 milestone Apr 23, 2025
@rmarinho rmarinho mentioned this pull request Apr 23, 2025
Closed
@bhavanesh2001 bhavanesh2001 deleted the fix_net10_27227 branch April 24, 2025 05:07
kubaflo added a commit to kubaflo/maui that referenced this pull request May 6, 2025
@kubaflo
Revert "[Android][NET 10] Fix: Ensure Image consumes touches properly (…
1fc80e1 
…dotnet#28429)"

This reverts commit a71e593.
github-actions bot pushed a commit that referenced this pull request May 9, 2025
@kubaflo
Revert "[Android][NET 10] Fix: Ensure Image consumes touches properly (…
4fb8895 
…#28429)"

This reverts commit a71e593.
rmarinho pushed a commit that referenced this pull request May 9, 2025
@github-actions @kubaflo
Revert "[Android][NET 10] Fix: Ensure Image consumes touches properly (…
df34cdc 
…#28429)" (#29419)

This reverts commit a71e593.

Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
rmarinho pushed a commit that referenced this pull request May 9, 2025
@kubaflo
Revert "[Android][NET 10] Fix: Ensure Image consumes touches properly (…
a50ae5d 
…#28429)" (#29363)

This reverts commit a71e593.
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-gestures Gesture types area-image Image loading, sources, caching community ✨ Community Contribution platform/android proposal/open
Projects
None yet
Milestone
.NET 10.0-preview4
Development

Successfully merging this pull request may close these issues.
4 participants
@bhavanesh2001 @jsuarezruiz @rmarinho @PureWeen