[Windows] Flyout Menu Icon disappears from Window Title Bar after Navigation #28240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Mar 7, 2025
|
but... shouldn't the menu button be unavailable when you navigate to some other page? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Mar 17, 2025
jsuarezruiz
previously approved these changes
Mar 26, 2025
|
@NirmalKumarYuvaraj Could you rebase and fix the conflict? |
1a5e601 to
3a95bbc
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Apr 11, 2025
…igation (dotnet#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
PureWeen
pushed a commit
that referenced
this pull request
Apr 11, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
…igation (#28240) * Fixed drawer toggle button visiblity * Update ToolbarExtensions.cs * added test cases * added shell test cases * Update NavigationPageToolbar.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
The Menu icon disappear after navigating to the second page from flyout.
Root Cause:
The anyPagesPushed function returned true, which caused the *drawerToggleVisible variable to be set to false. The visibility of the TogglePaneButton is determined by *drawerToggleVisible. As a result, the TogglePaneButton is not visible after navigation.
Description of Change:
Restricted the anyPagesPushed to non windows platforms.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #28130
Output
FlyoutPage
Before_flyout.mp4
After_flyout.mp4
Shell
Before_shell.mp4
After_shell.mp4