[iOS] Setting background color on the Searchbar - fix #23355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dartasen
reviewed
Jul 12, 2024
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
previously approved these changes
Jul 18, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
pictos
reviewed
Aug 11, 2024
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
|
@kubaflo @PureWeen I think I see another bug. Once a custom BackgroundColor has been set its not possible to return to the default color ( if (backGroundColor == null)
{
_hasCustomBackground = false;
backgroundView.Layer.CornerRadius = 0;
backgroundView.ClipsToBounds = false;
backgroundView.BackgroundColor = _defaultBackgroundColor;
textField.BackgroundColor = _defaultBackgroundColor;
return;
} |
|
/rebase |
872930d to
d40099e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
1d82e5c to
2a37248
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
cfaa9f4 to
1e10c16
Compare
mattleibow
approved these changes
May 13, 2025
There was a problem hiding this comment.
@kubaflo not sure if you had thoughts or observed exceptions when setting back to null?
That is technically a separate issue and you have probs fixed it already :)
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #23325
Fixes #24100