[iOS] Fixed picker title's color #20205
Merged
+57
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
reviewed
Jan 29, 2024
There was a problem hiding this comment.
The title color was not initialized or updated once the property changed? If it is in both cases, we must review this test and determine why it has not shown the issue so far. If it is the second case, a new test must be included.
I can help managing the tests.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
May 13, 2024
src/Controls/tests/UITests/snapshots/ios/PickerTitleShouldBeRed.png
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
b435c54 to
9cba474
Compare
|
/rebase |
9cba474 to
0f6879d
Compare
rmarinho
reviewed
Feb 24, 2025
e4428fe to
bf033d1
Compare
bf033d1 to
ea9b3e8
Compare
|
/rebase |
ea9b3e8 to
c7cb7f2
Compare
mattleibow
approved these changes
May 13, 2025
mattleibow
approved these changes
May 13, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
* Fixed picker title's color * Update PickerExtensions.cs
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
* Fixed picker title's color * Update PickerExtensions.cs
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* Fixed picker title's color * Update PickerExtensions.cs
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* Fixed picker title's color * Update PickerExtensions.cs
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
* Fixed picker title's color * Update PickerExtensions.cs
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* Fixed picker title's color * Update PickerExtensions.cs
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* Fixed picker title's color * Update PickerExtensions.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Before this change, the title of the picker hasn't been styled because of the UpdatePicker method. When the selected index was equal to -1 the platformPicker.AttributedPlaceholder has been overridden by platformPicker.Text
Issues Fixed
Fixes #19191
Screen.Recording.2024-01-28.at.13.24.16.mov