[clockkit] Add missing 'CLKComplicationFamily' enum values #4818
Conversation
From Xcode 10 GM API diff: https://github.com/xamarin/xamarin-macios/wiki/ClockKit-watchOS-xcode10-GM ``` diff --- /Applications/Xcode10-beta6.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS.sdk/System/Library/Frameworks/ClockKit.framework/Headers/CLKDefines.h 2018-08-10 17:39:53.000000000 -0400 +++ /Applications/Xcode10GM.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS.sdk/System/Library/Frameworks/ClockKit.framework/Headers/CLKDefines.h 2018-08-29 05:55:06.000000000 -0400 @@ -19,6 +19,10 @@ CLKComplicationFamilyCircularSmall = 4, CLKComplicationFamilyExtraLarge CLK_AVAILABLE_WATCHOS_IOS(3_0, 10_0) = 7, + CLKComplicationFamilyGraphicCorner CLK_AVAILABLE_WATCHOS_IOS(5_0, 12_0) = 8, + CLKComplicationFamilyGraphicBezel CLK_AVAILABLE_WATCHOS_IOS(5_0, 12_0) = 9, + CLKComplicationFamilyGraphicCircular CLK_AVAILABLE_WATCHOS_IOS(5_0, 12_0) = 10, + CLKComplicationFamilyGraphicRectangular CLK_AVAILABLE_WATCHOS_IOS(5_0, 12_0) = 11, }; ``` These are important enum values related to the new "graphic" complications types.
spouliot
left a comment
There was a problem hiding this comment.
minor: ordering is automatic, you do not need them unless they are not continuous
|
Build failure |
|
Build failure Test results1 tests failed, 0 tests skipped, 79 tests passed.Failed tests
|
|
Known test failure: https://github.com/xamarin/maccore/issues/649 |
|
Rookie question: when will this update be in one of the release channels? I need new watchOS 5 complications. |
So Xcode Preview 10 channel is behind stable now. OK, I see it new watchOS types now that I switched to Stable. Would be really helpful if a modal dialog warning was shown on VS.NET Mac launch or if manually check for new version if channel you are on is BEHIND a "higher" channel. |
See https://developercommunity.visualstudio.com/content/problem/340745/check-for-updates-needs-to-provide-status-of-behin.html and https://developercommunity.visualstudio.com/content/problem/340746/proactively-warn-user-if-they-are-on-update-channe.html. |
|
Hi @t9mike sorry for not answering earlier I totally missed your responses. My bad I apologize. Thanks for filing those issues against Visual Studio for Mac, your feedback seems valid to me, the team will investigate. Also it's a bit late now because you have the new enum values but in the future if we're ever missing enum values (we shouldn't!) know that you can just use the new values directly. So in an |
From Xcode 10 GM API diff: https://github.com/xamarin/xamarin-macios/wiki/ClockKit-watchOS-xcode10-GM
These are important enum values related to the new "graphic" complications types.