Skip to content

Fix http status code dead link #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Fix http status code dead link #2852

merged 2 commits into from
Aug 7, 2019

Conversation

CrosseyeJack
Copy link
Contributor

@CrosseyeJack CrosseyeJack commented Jul 28, 2019

Summary

The link pointing to the Http Status Codes on this page is dead and redirects back to microsoft.com so fixed it. Seems like it pointing to msdn2.microsoft.com which is dead so just used the docs.microsoft.com subdomain instead.

Can't create a go.microsoft.com link so used the long link instead.

Used GH's built in editor to make the change (cba to download the whole repo) so it moaned about the lack of new line at the end of the doc. I might do a search though the repo later on after I've finished work to see if this broken link exists else where.

The link pointing to the Http Status Codes is dead and redirects back to microsoft.com so fixed it. Seems like it pointing to msdn2.microsoft.com which is dead so just used the msdn.microsoft.com subdomain instead.

Can't create a go.microsoft.com link so used the long link instead.
@CrosseyeJack CrosseyeJack requested a review from scottaddie as a code owner July 28, 2019 15:25
@mairaw mairaw added this to the August 2019 milestone Jul 29, 2019
@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jul 29, 2019
@mairaw
Copy link
Contributor

mairaw commented Aug 6, 2019

@CrosseyeJack can you please apply my suggestion to this PR? Thanks.

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit 2c8edca into dotnet:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants