Fix remark about empty array #11625
Open
Fix remark about empty array #11625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
BillWagner
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
This LGTM @gewarren
I saw a few places where the code might be more clear using raw string literals, but that's optional.
Comment on lines
+11
to
+12
| Console.WriteLine($"The first vowel in \n {s}\n" + | ||
| $"is found at index {s.IndexOfAny(chars)}"); |
There was a problem hiding this comment.
suggestion: I would consider interpolated raw string literals here.
Comment on lines
+23
to
+27
| Console.WriteLine("The first character occurrence " + | ||
| $"from position {start} to {str.Length - 1}:"); | ||
| Console.WriteLine($"{Environment.NewLine}{br1}{Environment.NewLine}" + | ||
| $"{br2}{Environment.NewLine}{str}{Environment.NewLine}"); | ||
| Console.Write($"A character in '{target}' occurs at position: "); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11556