Flow Deterministic=true to repos #1618
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This *should* be a no-op until Deterministic supported is re-enabled via NuGet/Home#8601.
22 tasks
|
I suppose an alternative implementation is to set this property and this value at each repo level, instead of setting it here in the top-level build. |
|
I don't think there is a need for this. The .NET SDK already defaults Deterministic to true: https://github.com/dotnet/sdk/blob/86e7689b689c8ee7ac76998fa2c00dedf1e0518f/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L42 |
Agree. Rather than set this property globally I think we should add a build / PR check that fails if any shipping project does not have it set at compilation time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a no-op until Deterministic supported is re-enabled via NuGet/Home#8601.