Pre seek entry stream to 0 before computing content hash #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mmitche merged 2 commits into dotnet:release/10.0.1xx-preview7 from mmitche:seek-to-zero

Jul 22, 2025

+3 −1

Member

mmitche commented Jul 21, 2025

No description provided.


          Pre seek entry stream to 0 before computing content hash

7670ae2

github-project-automation bot added this to .NET Unified Build

Member Author

mmitche commented Jul 21, 2025

https://dev.azure.com/dnceng/internal/_build/results?buildId=2755062&view=results

tarekgh reviewed

View reviewed changes

src/arcade/src/Microsoft.DotNet.SignTool/src/ZipDataEntry.cs Outdated Show resolved Hide resolved


          Hoist into else

9fbdb79

hoyosjs approved these changes

View reviewed changes

mmitche enabled auto-merge (squash)

July 21, 2025 23:45

Member Author

mmitche commented Jul 21, 2025

Resolves #1403

ericstj reviewed

View reviewed changes

src/arcade/src/Microsoft.DotNet.SignTool/src/ZipDataEntry.cs Show resolved Hide resolved

ericstj approved these changes

View reviewed changes

Member

ericstj left a comment

Per discussion - the ownership issue can be addressed separately since it seems we're not hitting it here.

mmitche disabled auto-merge

July 22, 2025 16:06

mmitche merged commit 19deb21 into dotnet:release/10.0.1xx-preview7

10 checks passed

github-project-automation bot moved this to Done in .NET Unified Build

Member Author

mmitche commented Jul 22, 2025

dotnet/arcade#15985 for follow up item

Member

akoeplinger commented Jul 22, 2025

@mmitche should we port this one to main? or do you want to do it combined with the arcade follow up item?

Member Author

mmitche commented Jul 22, 2025

@mmitche should we port this one to main? or do you want to do it combined with the arcade follow up item?

Working on an arcade follow up PR.

Member Author

mmitche commented Jul 22, 2025

dotnet/arcade#15989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet