Include symbols in SB artifacts #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Jul 21, 2025
MichaelSimons
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1465
For building the VMR from a 2xx branch, we won't be building the repos of the shared component repos like runtime and aspnetcore. That means we don't have access to the symbols that would have been produced from these builds in order to include in the
dotnet-symbols-alltarball produced by a source-only build. These PDBs are necessary to include in that tarball.In order to get these PDBs included, we first need to have access to the PDBs that were produced from the build that produced the shared components. This updates the build so that the
dotnet-symbols-alltarball is added to the source build artifacts tarball. This will provide a 2xx build with access to these PDBs since it will consume the artifacts tarball as input.