Refactor Redis Clear Command to Use New CommandOptions API #4133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Redis clear command implementation to use the new CommandOptions API instead of the obsolete method overload. The change aligns with the latest .NET Aspire conventions and resolves potential warnings from deprecated API usage.
- Replaced obsolete WithCommand method parameters with new CommandOptions object
- Maintained all existing functionality for cache clearing and command state updates
- Removed some unnecessary blank lines for cleaner code formatting
Comments suppressed due to low confidence (1)
docs/fundamentals/snippets/custom-commands/AspireApp/AspireApp.AppHost/RedisResourceBuilderExtensions.cs:13
- [nitpick] Consider using a more descriptive variable name than 'commandOptions'. Since this is specifically for a clear cache command, 'clearCacheOptions' would be more meaningful.
var commandOptions = new CommandOptions
IEvangelist
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refactors the WithCommand method usage in RedisResourceBuilderExtensions to align with the latest .NET Aspire conventions.
Replaced obsolete method overload of WithCommand with the updated overload that uses CommandOptions.
Ensured UpdateState, IconName, and IconVariant are now passed through the new CommandOptions object.
Maintained existing logic for cache clearing and command state update.
This change ensures compatibility with the current Aspire APIs and resolves potential warnings from obsolete API usage.