This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove unnecessary char-related allocations #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes several unnecessary char-related allocations in System.IO.FileSystem. Most of them stemmed from appending the DirectorySeparatorChar to a string, which results in the compiler using String.Concat(..., object) for the concatenation, which means the char gets boxed. Others stemmed from array allocations that could have been cached, e.g. allocating an array for the directory separator chars on each call to TrimEnd. In fixing these, I also noticed and fixed a few places where duplicated logic could be replaced with a call to IsDirectoryChar.
|
Hi @stephentoub, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
stephentoub
added a commit
that referenced
this pull request
Jan 13, 2015
Remove unnecessary char-related allocations
aik-jahoda
added a commit
to aik-jahoda/corefx
that referenced
this pull request
Mar 15, 2021
* Credentials fixes * remove dead code * Update PostScenarioTest.cs Revert variable name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes several unnecessary char-related allocations in System.IO.FileSystem. Most of them stemmed from appending the DirectorySeparatorChar to a string, which results in the compiler using String.Concat(..., object) for the concatenation, which means the char gets boxed. Others stemmed from array allocations that could have been cached, e.g. allocating an array for the directory separator chars on each call to TrimEnd.
In fixing these, I also noticed and fixed a few places where duplicated logic could be replaced with a call to IsDirectoryChar.