Update version branding to rc1 #62889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version branding from preview to release candidate (rc1) for ASP.NET Core version 10.0.0. The changes prepare the codebase for a release candidate milestone by updating version iteration and labels.
Key changes:
- Updates pre-release version iteration from 7 to 1
- Changes pre-release version label from "preview" to "rc"
eng/Versions.props
Outdated
| @@ -18,7 +18,7 @@ | |||
| --> | |||
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> | |||
| <DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind> | |||
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | |||
| <PreReleaseVersionLabel>rc</PreReleaseVersionLabel> | |||
| <PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel> | |||
There was a problem hiding this comment.
The PreReleaseBrandingLabel still contains 'Preview' but should be updated to 'RC' to match the change from preview to rc branding. This will result in inconsistent version branding where the label says 'rc' but the branding says 'Preview 1'.
Suggested change
| <PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel> | |
| <PreReleaseBrandingLabel>RC $(PreReleaseVersionIteration)</PreReleaseBrandingLabel> |
Copilot uses AI. Check for mistakes.
wtgodbe
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates version branding in eng/Versions.props to rc1