Add gRPC JSON transcoding option for case insensitive field names #62868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a FieldNamesCaseInsensitive option to the gRPC JSON transcoding feature, allowing case-insensitive matching of field names during JSON deserialization.
Key changes:
- Added a new
FieldNamesCaseInsensitiveboolean property toGrpcJsonSettingsclass - Modified the JSON serializer configuration to respect the case-insensitive setting
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
GrpcJsonSettings.cs |
Added the new FieldNamesCaseInsensitive property with documentation explaining interoperability concerns |
JsonConverterHelper.cs |
Updated to configure PropertyNameCaseInsensitive based on the new setting |
MessageTypeInfoResolver.cs |
Removed unused import statement |
JsonConverterReadTests.cs |
Added extensive test cases to verify case-insensitive field matching behavior |
transcoding.proto |
Added test message type for field name case testing |
Comments suppressed due to low confidence (1)
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs:515
- This test case for MapKeyBool_CaseInsensitive is missing the settings parameter to enable case-insensitive matching. It should include
settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true }to properly test the case-insensitive functionality.
AssertReadJson<HelloRequest>(json, serializeOld: false);
...est/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs
Show resolved
Hide resolved
captainsafia
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
FieldNamesCaseInsensitivesetting to gRPC JSON transcoding.Fixes #50401