Only run template tests when templates change #62481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -582,10 +582,10 @@ stages: | |||
| /p:VsTestUseMSBuildOutput=false | |||
| displayName: Build shared fx | |||
| # -noBuildRepoTasks -noBuildNative -noBuild to avoid repeating work done in the previous step. | |||
| - script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -nobl -all -noBuildRepoTasks -noBuildNative -noBuild -test | |||
| - script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -all -noBuildRepoTasks -noBuildNative -noBuild -test | |||
wtgodbe
commented
Jun 26, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a targeted Helix job that only runs template tests when files under src/ProjectTemplates change, and updates existing CI pipelines to skip those tests by default.
- Introduces
OnlyTestProjectTemplatesMSBuild property and uses it to filter which projects are built/tested. - Adds a new Azure pipeline (
template-tests-pr.yml) triggered on template folder changes. - Updates
ci.ymlandci-public.ymlto disable template tests by settingRunTemplateTests=false.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/helix/helix.proj | Added OnlyTestProjectTemplates condition to include only template test projects. |
| eng/Build.props | Wrapped import of RequiresDelayedBuildProjects.props in the new property condition. |
| .azure/pipelines/template-tests-pr.yml | New pipeline definition to run template tests on PRs touching ProjectTemplates. |
| .azure/pipelines/ci.yml | Updated Helix build invocation to skip template tests by default. |
| .azure/pipelines/ci-public.yml | Updated public CI invocation similarly to skip template tests. |
Comments suppressed due to low confidence (4)
.azure/pipelines/ci.yml:637
- The
-noblflag was removed here, which changes the build invocation from the original. You should include-noblto preserve the intended behavior.
- script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -all -noBuildRepoTasks -noBuildNative -noBuild -test
.azure/pipelines/ci-public.yml:585
- The
-noblflag was removed here as well, unintentionally altering the build behavior. Please restore-noblto match the original invocation.
- script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -all -noBuildRepoTasks -noBuildNative -noBuild -test
.azure/pipelines/ci.yml:639
- You’re setting
RunTemplateTests=falsebut the code usesOnlyTestProjectTemplatesto gate template test execution. Rename or duplicate this property so the MSBuild condition works correctly.
/p:CrossgenOutput=false /p:RunTemplateTests=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
.azure/pipelines/ci-public.yml:588
- This also uses
RunTemplateTests, which doesn’t match theOnlyTestProjectTemplatesproperty in your MSBuild scripts. Use the same property name to ensure the skip logic actually takes effect.
/p:VsTestUseMSBuildOutput=false /p:RunTemplateTests=false
|
Helix took 1h 9m here, down from an average of about 2h |
BrennanConroy
approved these changes
Jun 26, 2025
MackinnonBuck
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should significantly cut down on the time it takes to run Helix jobs (@BrennanConroy reports almost an hour of time save). Also adds a new job that will only run when the ProjectTemplates folder is touched, which runs just the template tests in Helix.
Note - some template tests run only in the local jobs. Those will still run in all PRs (but those ones are very quick)