Skip to content

[Identity] Fix Identity UI asset definitions #59100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[Identity] Fix Identity UI asset definitions #59100

merged 1 commit into from
Apr 29, 2025

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Nov 22, 2024 •
edited
Loading

Backport of #55218

  • Fix the package definitions for Identity UI as they were wrong and break when compiled against a newer (10.0) SDK.
  • Previously, if we didn't find the endpoints for the assets, they would get re-generated on the fly.
  • As part of optimizing our build performance we reduce the cases in which that happened.
  • As a result, the identity UI endpoints (which were incorrectly defined) no longer are defined on the flight and break.
  • This fix corrects the endpoints that are embedded into the package and avoids the need to re-generate them.

@ghost ghost added the area-identity Includes: Identity and providers label Nov 22, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Nov 22, 2024
@javiercn javiercn mentioned this pull request Nov 22, 2024
Closed
@javiercn javiercn linked an issue Nov 22, 2024 that may be closed by this pull request
[Identity][UI] Fix asset path for endpoint definitions #58841
Closed
@javiercn
Copy link
Member Author

No longer technically needed as it was addressed/worked around on the 10.0 SDK dotnet/sdk#47734. We only want to take it if we want to reduce the work the build does, but it shouldn't be a significant change.

@javiercn javiercn marked this pull request as ready for review April 29, 2025 17:34
@wtgodbe wtgodbe added the Servicing-consider Shiproom approval is required for the issue label Apr 29, 2025
@wtgodbe wtgodbe merged commit e790785 into release/9.0 Apr 29, 2025
25 checks passed
@wtgodbe wtgodbe deleted the javiercn/fix-identity-ui-package-def branch April 29, 2025 17:53
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.5 Apr 29, 2025
@dotnet-policy-service dotnet-policy-service bot modified the milestone: 9.0.5 Apr 29, 2025
@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Apr 29, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hi @@javiercn. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@renovate renovate bot mentioned this pull request Jul 11, 2025
Open
1 task
This was referenced Jul 21, 2025
Open
Open
Open
Closed
Open
Open
Closed
Open
Open
Open
Open
This was referenced Jul 23, 2025
Open
Open
Open
Closed
Open
Open
Open
Closed
Closed
Closed
Open
Open
Open
Open
Closed
Closed
Open
Open
Closed
Closed
Merged
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
9.0.5
Development

Successfully merging this pull request may close these issues.

[Identity][UI] Fix asset path for endpoint definitions
3 participants
@javiercn @wtgodbe @rbhanda