Update aspire deploy command to use temporary directory as default output path #10642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput path Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
aspire deploy command should be updated to use a temporary output directory as the default output path when none is provided as an argument.
Copilot finished work on behalf of
captainsafia
July 23, 2025 23:10
davidfowl
reviewed
Jul 23, 2025
…f manual GUID approach Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
July 23, 2025 23:36
Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Updates the aspire deploy command to use temporary directories as the default output path instead of creating a deploy subdirectory in the current working directory. This change improves isolation between deploy operations and prevents directory clutter.
- Changed default output path generation to use system temporary directories with unique naming
- Added comprehensive unit test to verify the new temporary directory behavior
- Maintains backward compatibility for users specifying custom
--output-pathvalues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/DeployCommand.cs | Modified GetDefaultOutputPath to generate unique temporary directories using Directory.CreateTempSubdirectory |
| tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs | Added unit test to verify temporary directory usage and validate naming patterns |
captainsafia
approved these changes
Jul 24, 2025
davidfowl
reviewed
Jul 24, 2025
| @@ -24,7 +24,7 @@ public DeployCommand(IDotNetCliRunner runner, IInteractionService interactionSer | |||
|
|
|||
| protected override string GetOutputPathDescription() => DeployCommandStrings.OutputPathArgumentDescription; | |||
|
|
|||
| protected override string GetDefaultOutputPath(ArgumentResult result) => Path.Combine(Environment.CurrentDirectory, "deploy"); | |||
| protected override string GetDefaultOutputPath(ArgumentResult result) => Directory.CreateTempSubdirectory("aspire-deploy-").FullName; | |||
There was a problem hiding this comment.
Feels weird that calling this twice will make a new directory. Should this be changed to CreateDefaultOutputPath?
There was a problem hiding this comment.
Good point! Renamed the method to CreateDefaultOutputPath to make it clear that it has side effects and creates a new directory each time it's called. This clarifies the semantic difference from a simple getter. Change implemented in commit fd42658.
…e effects Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
July 24, 2025 02:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
aspire deploycommand to use a temporary output directory as the default when no--output-pathis specified, instead of using{current-directory}/deploy.Problem
Previously, the
aspire deploycommand would default to creating deployment artifacts in adeploysubdirectory of the current working directory. This could lead to:Solution
Modified
DeployCommand.GetDefaultOutputPath()to generate unique temporary directories:Before:
After:
Benefits
Path.GetTempPath()for platform compatibility--output-pathExample
Testing
DeployCommandUsesTemporaryDirectoryAsDefaultOutputPathto verify the new behaviorThe change is minimal and surgical - only one line modified in the core functionality while maintaining all existing behavior for users who specify custom output paths.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.