fix: aspire exec fail fast improvements
#10606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the aspire exec command to validate required arguments (specifically the --resource parameter) before attempting to locate the AppHost project, ensuring faster failure when user input is invalid.
Key changes:
- Moves argument validation logic earlier in the execution flow to fail fast on invalid input
- Adds a test to verify the new fail-fast behavior with a timeout assertion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/ExecCommand.cs | Moves target resource and command token validation to occur before project location and build operations |
| tests/Aspire.Cli.Tests/Commands/ExecCommandTests.cs | Adds test case to verify fast failure when --resource is not specified |
aspire exec should fail fast if --resource not specifiedaspire exec fail fast improvements
JamesNK
reviewed
Jul 23, 2025
JamesNK
approved these changes
Jul 23, 2025
DeagleGross
added a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of searching for apphost project,
aspire execshould firstly validate all arguments to fail fast if something is wrong with the user input.Also if no command is passed, aspire exec should report that
Fixes #10591
Fixes #10592