Fix TransportOptionsValidator to accept valid Kestrel binding addresses #10595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
July 22, 2025 07:39
|
Do the same for TryValidateGrpcEndpointUrl |
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Applied the same BindingAddress.Parse() fix to TryValidateGrpcEndpointUrl method. Now both application URLs and GRPC endpoint URLs consistently use BindingAddress validation instead of Uri.TryCreate(), allowing valid Kestrel binding addresses like |
Copilot finished work on behalf of
davidfowl
July 22, 2025 07:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TransportOptionsValidatorwas usingUri.TryCreate()to validate binding addresses, which is too strict and rejects valid Kestrel binding addresses likehttps://0:0:0:0:17008. This caused host startup failures with the error:Changes Made
TransportOptionsValidator.cs:using Microsoft.AspNetCore.Http;to accessBindingAddressUri.TryCreate()withBindingAddress.Parse()for validating application URLsTryParseBindingAddresshelper method following the same pattern used inDashboardOptions.csValidation
The fix correctly handles various address formats:
Uri.TryCreate()(old)BindingAddress.Parse()(new)https://0:0:0:0:17008https://localhost:5000https://[::1]:9000invalid-addressThis approach aligns with how other parts of the Aspire codebase handle binding address validation and ensures that all valid Kestrel binding addresses are accepted.
Fixes #10593.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.