Build ServiceDiscovery library and tests against .NET Framework #10470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adb78e1 to
aa30c55
Compare
This enables scenarios to use the library on .NET Framework. This is mostly done by using C# 14 new extension syntax so very little code changes were made but rather the APIs that didn't exist are added into FrameworkExtensions classes to light them up on .NET Core builds.
aa30c55 to
17f3a62
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables the ServiceDiscovery library and its tests to build and run on .NET Framework by multi-targeting the projects and providing polyfills for newer APIs via C# 14 extension syntax.
- Multi-target key projects and tests against net462/net472 alongside existing frameworks.
- Added a shared
FxPolyfillsfolder with extension methods to surface missing .NET Core APIs on .NET Framework. - Updated test and service discovery projects to conditionally include additional references and imports.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Shared/TemplatesTesting/Aspire.Shared.TemplatesTesting.targets | Added IncludeTestUtilities property and removed direct test utilities reference |
| tests/Microsoft.Extensions.ServiceDiscovery.Tests/…Tests.cs | Suppressed a type conflict warning around the fake resolver factory |
| tests/**/*.csproj | Switched to multi-targeting net472 on Windows and added framework-specific package imports |
| tests/Aspire.TestUtilities/Aspire.TestUtilities.csproj | Multi-target net472 and import polyfills targets for framework support |
| src/Shared/FxPolyfills/*.cs | Introduced extension polyfills for various System and threading APIs on .NET Framework |
| src/Shared/FxPolyfills/FxPolyfills.targets | Configured inclusion/exclusion of polyfill sources based on targeting |
| src/Microsoft.Extensions.ServiceDiscovery*.csproj | Multi-target net462, conditional AOT flag, reference Bcl packages, and import polyfills |
| src/Microsoft.Extensions.ServiceDiscovery/ServiceDiscoveryHttpClientBuilderExtensions.cs | Wrapped gRPC-disable filter in #if NET for proper cross-target behavior |
| eng/Versions.props & Directory.Packages.props | Added and updated version properties for newly referenced packages |
Comments suppressed due to low confidence (3)
tests/Shared/TemplatesTesting/Aspire.Shared.TemplatesTesting.targets:18
- The ProjectReference to
Aspire.TestUtilitieswas removed, which may break resolution of theRequiresDockerattribute and other test utilities. Please re-add or replace this reference so that the shared test utilities are included in the build.
</ItemGroup>
src/Shared/FxPolyfills/Task.cs:20
- Add unit tests for
FxPolyfillTask.ConfigureAwaitcovering eachConfigureAwaitOptionspath to ensure the polyfill behaves identically to its .NET Core counterpart.
public async Task ConfigureAwait(ConfigureAwaitOptions options)
src/Shared/FxPolyfills/Task.TimeProvider.cs:12
- Consider adding tests for
FxPolyfillTask.WaitAsyncto validate timeout and cancellation behavior on .NET Framework scenarios.
public Task WaitAsync(CancellationToken token)
|
These polyfills are excellent. I wish there was an official MS polyfill for net4x, to prevent multiple copies of classes/code in each dll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables scenarios to use the library on .NET Framework. This is mostly done by using C# 14 new extension syntax so very little code changes were made but rather the APIs that didn't exist are added into FrameworkExtensions classes to light them up on .NET Core builds.
NOTE: This updates the abstractions and main ServiceDiscovery library, but does not enable the DNS nor YARP. YARP isn't supported on framework, so that isn't necessary. The DNS has a larger change due to more APIs it's using that don't exist, so once this PR gets in I can push that up if this pattern works.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate