Don't try to copy files that no longer exist #9941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: b7e21ad b7e21ad moved `src/native/monodroid/` to `src/native/mono/monodroid` in order to add a parallel tree for the CoreCLR host. However, the `xaprepare` code which used to copy certain files from that directory wasn't updated, resulting in errors on CI similar to: Step Xamarin.Android.Prepare.Step_CopyExtraResultFilesForCI failed: Could not find a part of the path '/Users/runner/work/1/s/src/native/monodroid'. System.InvalidOperationException: Step Xamarin.Android.Prepare.Step_CopyExtraResultFilesForCI failed: Could not find a part of the path '/Users/runner/work/1/s/src/native/monodroid'. ---> System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/runner/work/1/s/src/native/monodroid'. Fix the error by removing the offending line from `xaprepare` completely, as we no longer have any `*.include.*` files there. There used to be serialized mono config and library mapping files here, but we no longer use them.
pjcollins
approved these changes
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: b7e21ad
b7e21ad moved
src/native/monodroid/tosrc/native/mono/monodroidin order toadd a parallel tree for the CoreCLR host. However, the
xapreparecode which usedto copy certain files from that directory wasn't updated, resulting in errors on
CI similar to:
Fix the error by removing the offending line from
xapreparecompletely, as we nolonger have any
*.include.*files there. There used to be serialized mono configand library mapping files here, but we no longer use them.