[XABT] Don't run _LinkAssembliesNoShrink when $(PublishTrimmed) = true.
#9887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Mar 6, 2025
Comment on lines
1465
to
+1467
| <Target Name="_LinkAssembliesNoShrink" | ||
| DependsOnTargets="_LinkAssembliesNoShrinkInputs" | ||
| Condition="'$(AndroidLinkMode)' == 'None'" | ||
| Condition="'$(PublishTrimmed)' != 'true'" |
There was a problem hiding this comment.
I think this should work, based on the defaults:
Is there an example error when this breaks?
There was a problem hiding this comment.
There isn't an error, it successfully runs _LinkAssembliesNoShrink after ILLink.
_LinkAssembliesNoShrink operates on the copies in obj\Release\net10.0-android\android\assets instead of obj\Release\net10.0-android\android-arm64\linked, so the work it performs is just ignored.
However it interferes with my attempts to scan for JLO types in a link step.
There was a problem hiding this comment.
Can we add a test which checks that the targets are skipped (or not) in the correct configurations?
Context: https://github.com/dotnet/android/issues/9526
Today, we need to run *either* `ILLink` or `_LinkAssembliesNoShrink`.
However, they have different triggers:
- `ILLink`: [`$(PublishTrimmed)=true`][0]
- `_LinkAssembliesNoShrink`: `$(AndroidLinkMode)=None`
These can get out of sync, particularly when using global properties,
causing both to be run.
Update the `_LinkAssembliesNoShrink` target to trigger when
`$(PublishTrimmed)` != `true` to ensure that we don't run it if
`ILLink` is being run.
[0]: https://github.com/dotnet/runtime/blob/f63d96e434576ae81a105a7e52634a877058b978/src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets#L92-L96 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #9526
Today, we need to run either
ILLinkor_LinkAssembliesNoShrink, however they have different triggers:ILLink-$(PublishTrimmed)=true_LinkAssembliesNoShrink-$(AndroidLinkMode)=NoneThese can get out of sync, particularly when using global properties, causing both to be run.
Update
_LinkAssembliesNoShrinkto trigger when$(PublishTrimmed)!=trueto ensure that we don't run it ifILLinkis being run.