Skip to content

[Mono.Android-Tests] Ignore more types of temporary network/server failures. #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

[Mono.Android-Tests] Ignore more types of temporary network/server failures. #9871

merged 1 commit into from
Mar 5, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 3, 2025

CI tests are failing with:

System.Net.Http.HttpRequestException : net_http_message_not_success_statuscode_reason, 503, Service Temporarily Unavailable
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at Xamarin.Android.NetTests.AndroidHandlerTestBase.EnsureSuccessStatusCode(HttpResponseMessage response)
   at Xamarin.Android.NetTests.AndroidHandlerTestBase.Redirect_POST_With_Content_Works()
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

Add several additional HTTP 50X codes that indicate temporary network/server failures to the list of status codes that should be ignored in EnsureSuccessStatusCode.

@jpobst jpobst force-pushed the dev/jpobst/http-500 branch from 51bd5a9 to e6fac1e Compare March 4, 2025 20:10
@jpobst jpobst marked this pull request as ready for review March 4, 2025 22:53
@jpobst jpobst requested a review from jonpryor as a code owner March 4, 2025 22:53
@jpobst jpobst requested a review from pjcollins March 4, 2025 22:53
jonathanpeppers
jonathanpeppers approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some of these on PRs yesterday. 👍

@jonathanpeppers jonathanpeppers merged commit 455ec0a into main Mar 5, 2025
58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/jpobst/http-500 branch March 5, 2025 14:42
@jpobst jpobst mentioned this pull request Mar 19, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor

@pjcollins pjcollins Awaiting requested review from pjcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpobst @jonathanpeppers