[Mono.Android] use Java.Lang.Object.GetObject<T>()
#9860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f800c1a was a step toward making `Java.Lang.Object.GetObject<T>()` to not call the static `Java.Interop.TypeManager.CreateInstance()` and go through a `JniRuntime.JniValueManager` instead. Unfortunately, there are still a few types that manually call `TypeManager.CreateInstance()`, these will error when running with NativeAOT such as `Mono.Android.NET-Tests`: 02-27 14:40:23.089 9462 9487 I NUnit : AssetContents("asset1.txt","Asset1") 02-27 14:40:23.093 9462 9487 E NUnit : [FAIL] 02-27 14:40:23.093 9462 9487 E NUnit : : System.DllNotFoundException : DllNotFound_Linux, xa-internal-api, 02-27 14:40:23.093 9462 9487 E NUnit : dlopen failed: library "xa-internal-api.so" not found 02-27 14:40:23.093 9462 9487 E NUnit : dlopen failed: library "libxa-internal-api.so" not found 02-27 14:40:23.093 9462 9487 E NUnit : dlopen failed: library "xa-internal-api" not found 02-27 14:40:23.093 9462 9487 E NUnit : dlopen failed: library "libxa-internal-api" not found 02-27 14:40:23.093 9462 9487 E NUnit : at System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) + 0x4c 02-27 14:40:23.093 9462 9487 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.FixupModuleCell(InteropHelpers.ModuleFixupCell*) + 0x134 02-27 14:40:23.093 9462 9487 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.ResolvePInvokeSlow(InteropHelpers.MethodFixupCell*) + 0x40 02-27 14:40:23.093 9462 9487 E NUnit : at Android.Runtime.RuntimeNativeMethods.monodroid_TypeManager_get_java_class_name(IntPtr klass) + 0x2c 02-27 14:40:23.093 9462 9487 E NUnit : at Java.Interop.TypeManager.GetClassName(IntPtr) + 0x10 02-27 14:40:23.093 9462 9487 E NUnit : at Java.Interop.TypeManager.CreateInstance(IntPtr, JniHandleOwnership, Type) + 0x44 02-27 14:40:23.093 9462 9487 E NUnit : at Android.Runtime.InputStreamInvoker.FromJniHandle(IntPtr handle, JniHandleOwnership transfer) + 0x60 02-27 14:40:23.093 9462 9487 E NUnit : at Android.Content.Res.AssetManager.Open(String) + 0x88 02-27 14:40:23.093 9462 9487 E NUnit : at Android.Content.ResTests.AssetManagerTests.AssetContents(String asset, String expected) + 0x34 02-27 14:40:23.093 9462 9487 E NUnit : at libMono.Android.NET-Tests!<BaseAddress>+0x155be18 02-27 14:40:23.093 9462 9487 E NUnit : at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x84 Update `InputStreamInvoker`, `OutputStreamInvoker`, and `XmlPullParserReader` to use `Java.Lang.Object.GetObject<T>()` instead.
5b09113 to
4109448
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f800c1a was a step toward making
Java.Lang.Object.GetObject<T>()to not call the staticJava.Interop.TypeManager.CreateInstance()and go through aJniRuntime.JniValueManagerinstead.Unfortunately, there are still a few types that manually call
TypeManager.CreateInstance(), these will error when running with NativeAOT such asMono.Android.NET-Tests:Update
InputStreamInvoker,OutputStreamInvoker, andXmlPullParserReaderto useJava.Lang.Object.GetObject<T>()instead.