[XABT] Refactor marshal methods and type map generation out of GenerateJavaStubs.
#9850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89fd040 to
4ba113e
Compare
4ba113e to
0d79ba4
Compare
Comment on lines
+1557
to
+1564
| <GenerateTypeMappings | ||
| AndroidRuntime="$(_AndroidRuntime)" | ||
| Debug="$(AndroidIncludeDebugSymbols)" | ||
| GenerateNativeAssembly="$(_AndroidGenerateNativeAssembly)" | ||
| IntermediateOutputDirectory="$(IntermediateOutputPath)" | ||
| SkipJniAddNativeMethodRegistrationAttributeScan="$(_SkipJniAddNativeMethodRegistrationAttributeScan)" | ||
| TypemapOutputDirectory="$(_NativeAssemblySourceDir)"> | ||
| </GenerateTypeMappings> |
There was a problem hiding this comment.
Can the whole task be skipped in some cases?
bool useMarshalMethods = !Debug && EnableMarshalMethods;
if (!useMarshalMethods)
return true;I think it would be clearer if a Condition did this part, since it's refactored into one task now. 👍
The Condition would also be logged in a build log, where the existing code doesn't log.
01ae9ae to
e07546c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #9827
Continue breaking down the
<GenerateJavaStubs>task into smaller, more manageable pieces by moving the marshal methods and type map generation steps into separate tasks. Once this is complete, we should be able to start moving these steps that require Cecil assembly scanning into linker steps (or equivalent), eventually saving a Cecil assembly scan per build.