[nativeaot] support multi-RID builds #9826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/dotnet/sdk/blob/68bf4cbabc023e5c2752ee4d5ce7e4a40929e748/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RuntimeIdentifierInference.targets#L227-L229 The only blocker for supporting `$(RuntimeIdentifiers)=android-arm64;android-x64` is the error message: error NETSDK1191: A runtime identifier for the property 'PublishAot' couldn't be inferred. Specify a rid explicitly. We can set `$(AllowPublishAotWithoutRuntimeIdentifier)` by default, as this is not an error we'd ever want to show on Android. After this change I can see the MSBuild terminal logger shows the two RIDs building in parallel: NativeAOT IlcCompile (8.7s) NativeAOT IlcCompile (8.6s) And then the resulting `.apk` has both `lib/arm64-v8a` and `lib/x86_64`. I also updated some of our MSBuild test infrastructure to make it easier to parameterize more MSBuild tests for `$(PublishAot)=true` in the future. We'll likely want to do tests like: [Test] public void SomeTest ([Values (true, false)] bool publishAot) { var proj = new XamarinAndroidApplicationProject (); if (publishAot) { proj.SetPublishAot (true, AndroidNdkPath); } //... }
|
Does this mean we can now target |
|
NativeAOT is still a prototype, the next several .NET 10 previews will likely emit a warning similar to: It will be a good time to test and file issues though, thanks! |
|
Thank you for elaborating! Just to avoid unnecessary checkups, is it available in dotnet 10 Preview 1? |
No.
JNI support and System.Cryptography are two totally independent things. System.Security.Cryptography depends on producing NativeAOT runtime packs targeting android-[arm64/x64/...] instead of linux-bionix-[...]. That's not done yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/dotnet/sdk/blob/68bf4cbabc023e5c2752ee4d5ce7e4a40929e748/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RuntimeIdentifierInference.targets#L227-L229
The only blocker for supporting
$(RuntimeIdentifiers)=android-arm64;android-x64is the error message:We can set
$(AllowPublishAotWithoutRuntimeIdentifier)by default, as this is not an error we'd ever want to show on Android.After this change I can see the MSBuild terminal logger shows the two RIDs building in parallel:
And then the resulting
.apkhas bothlib/arm64-v8aandlib/x86_64.I also updated some of our MSBuild test infrastructure to make it easier to parameterize more MSBuild tests for
$(PublishAot)=truein the future.We'll likely want to do tests like: