[Xamarin.Android.Build.Tasks] use mono.android.jar only for $(AndroidCodegenTarget)=XAJavaInterop1
#9813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oidCodegenTarget)=XAJavaInterop1`
`mono.android.jar/dex` are compiled with
`$(AndroidCodegenTarget)=XAJavaInterop1`, and so this causes a problem
if you build a project targeting `$(AndroidCodegenTarget)=JavaInterop1`
as incorrect Java stubs will be used.
For example, `dotnet new maui` using NativAOT we can get a crash such as:
02-14 16:23:29.884 19260 19260 E .hellonativeaot: No implementation found for void mono.android.Runtime.register(java.lang.String, java.lang.Class, java.lang.String) (tried Java_mono_android_Runtime_register and Java_mono_android_Runtime_register__Ljava_lang_String_2Ljava_lang_Class_2Ljava_lang_String_2) - is the library loaded, e.g. System.loadLibrary?
Which is caused by `mono.android.Runtime.register` being called by
`mono/android/view/View_OnClickListenerImplementor.java` which is
compiled with `$(AndroidCodegenTarget)=XAJavaInterop1`.
To fix this:
* Several places already check if `$(_AndroidUseMarshalMethods)=true`
and skip usage of `mono.android.jar`.
* Add an additional check to verify `$(AndroidCodegenTarget)=XAJavaInterop1`
Previously, `$(AndroidCodegenTarget)` was also allowed to blank and
default to `XAJavaInterop1`, but it seems better to explicitly set it.
I also updated the `NativAOT()` test to verify
`mono/android/views/View_OnClickListenerImplementor.java` is generated
on disk.
dellis1972
approved these changes
Feb 20, 2025
grendello
pushed a commit
that referenced
this pull request
Feb 21, 2025
…oidCodegenTarget)=XAJavaInterop1` (#9813) `mono.android.jar` and `mono.android.dex` are compiled with `$(AndroidCodegenTarget)=XAJavaInterop1`. This causes problems if you build a project with `$(AndroidCodegenTarget)=JavaInterop1` as the wrong set of Java stubs will be used. For example, `dotnet new maui` using NativAOT we can get a crash such as: E .hellonativeaot: No implementation found for void mono.android.Runtime.register(java.lang.String, java.lang.Class, java.lang.String) (tried Java_mono_android_Runtime_register and Java_mono_android_Runtime_register__Ljava_lang_String_2Ljava_lang_Class_2Ljava_lang_String_2) - is the library loaded, e.g. System.loadLibrary? Which is caused by `mono.android.Runtime.register()` being called by `mono/android/view/View_OnClickListenerImplementor.java` which is compiled with `$(AndroidCodegenTarget)=XAJavaInterop1`. To fix this: * Several places already check if `$(_AndroidUseMarshalMethods)=true` and skip usage of `mono.android.jar`. * Add an additional check to verify `$(AndroidCodegenTarget)=XAJavaInterop1` Previously, `$(AndroidCodegenTarget)` was also allowed to be blank and default to `XAJavaInterop1`, but it seems better to explicitly set it. I also updated `BuildTest2.NativAOT()` to verify that `mono/android/views/View_OnClickListenerImplementor.java` is generated on disk.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mono.android.jar/dexare compiled with$(AndroidCodegenTarget)=XAJavaInterop1, and so this causes a problem if you build a project with$(AndroidCodegenTarget)=JavaInterop1as incorrect Java stubs will be used.For example,
dotnet new mauiusing NativeAOT we can get a crash such as:Which is caused by
mono.android.Runtime.registerbeing called bymono/android/view/View_OnClickListenerImplementor.javawhich is compiled with$(AndroidCodegenTarget)=XAJavaInterop1.To fix this:
Several places already check if
$(_AndroidUseMarshalMethods)=trueand skip usage ofmono.android.jar.Add an additional check to verify
$(AndroidCodegenTarget)=XAJavaInterop1Previously,
$(AndroidCodegenTarget)was also allowed to blank and default toXAJavaInterop1, but it seems better to explicitly set it.I also updated the
NativAOT()test to verifymono/android/views/View_OnClickListenerImplementor.javais generated on disk.