Skip to content

[Xamarin.Android.Build.Tasks] move .NET 8 support to android-net8 workload #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

jonathanpeppers
Copy link
Member

Context: #9777

The problem with #9777, is it increases our install size by something like ~700MB with the following packs:

  • Microsoft.Android.Sdk.[platform] x 1 (current platform)
  • Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.[RID] x 4 RIDs
  • Microsoft.NETCore.App.Runtime.Mono.[RID] x 4 RIDs

Some of .NET MAUI's CI machines are extremely tight on disk space, and we promptly filled the disk!

Let's move these packs to a new android-net8 workload, which can be installed separately.

dotnet/android-libraries could simply install:

dotnet workload install android-net8

Which would provision both android and android-net8 workloads.

…orkload

Context: #9777

The problem with #9777, is it increases our install size by something
like ~700MB with the following packs:

* Microsoft.Android.Sdk.[platform] x 1 (current platform)
* Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.[RID] x 4 RIDs
* Microsoft.NETCore.App.Runtime.Mono.[RID] x 4 RIDs

Some of .NET MAUI's CI machines are extremely tight on disk space, and
we promptly filled the disk!

Let's move these packs to a new `android-net8` workload, which can be
installed separately.

dotnet/android-libraries could simply install:

    dotnet workload install android-net8

Which would provision both `android` and `android-net8` workloads.
@jonathanpeppers
Copy link
Member Author

net8.0 tests are still working:

image

@jonathanpeppers jonathanpeppers marked this pull request as ready for review February 12, 2025 22:23
Copy link
Contributor

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpeppers jonathanpeppers merged commit ff4c6d4 into main Feb 14, 2025
58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/android-net8 branch February 14, 2025 15:52
grendello added a commit that referenced this pull request Feb 14, 2025
* main:
  [CoreCLR] Add src/native/clr for CoreCLR hosting bits (#9778)
  [Xamarin.Android.Build.Tasks] move .NET 8 support to `android-net8` workload (#9785)
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants