[coreclr] projects with UseMonoRuntime=false successfully build
#9754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards Android projects using `UseMonoRuntime=false` successfully: 1. Create new packs such as `Microsoft.Android.Runtime.CoreCLR.[api].[rid]` 2. Ensure a project *builds* with `UseMonoRuntime=false` in both `Debug` and `Release` configurations. 3. The project will not be able to run successfully yet. (Significant work required for no. 3)
dellis1972
approved these changes
Feb 5, 2025
This comment was marked as outdated.
This comment was marked as outdated.
dellis1972
approved these changes
Feb 5, 2025
dellis1972
reviewed
Feb 5, 2025
| Path.Combine (XABuildPaths.BuildOutputDirectory, "nuget-unsigned"), | ||
| } | ||
| }; | ||
| proj.SetProperty ("UseMonoRuntime", "false"); // Enables CoreCLR |
There was a problem hiding this comment.
Is this one bool property going to be enough? As we will have MonoVM, CoreCLR and NativeAOT?
There was a problem hiding this comment.
The logic is here:
But yeah, I think they need to invent a new property. $(PublishAot) and $(UseMonoRuntime) are what iOS uses currently.
|
Latest build produces new packs:
|
ivanpovazan
reviewed
Feb 5, 2025
Comment on lines
-30
to
+31
| <Import Project="Microsoft.Android.Sdk.NativeAOT.targets" Condition=" '$(_AndroidRuntime)' == 'NativeAOT' And '$(DesignTimeBuild)' != 'true' " /> | ||
| <Import Project="Microsoft.Android.Sdk.CoreCLR.targets" Condition=" '$(_AndroidRuntime)' == 'CoreCLR' " /> | ||
| <Import Project="Microsoft.Android.Sdk.NativeAOT.targets" Condition=" '$(_AndroidRuntime)' == 'NativeAOT' " /> |
There was a problem hiding this comment.
Just curious, why was there: '$(DesignTimeBuild)' != 'true' before ?
There was a problem hiding this comment.
I think this was accidental in an unrelated change: 9ed1469
When I saw it, felt like it would be wrong because it would prevent NativeAOT packs from being used in a design-time build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards Android projects using
UseMonoRuntime=falsesuccessfully:Create new packs such as
Microsoft.Android.Runtime.CoreCLR.[api].[rid]Ensure a project builds with
UseMonoRuntime=falsein bothDebugandReleaseconfigurations.The project will not be able to run successfully yet.
(Significant work required for no. 3)