Skip to content

[XABT] Add deprecation warning for $(AndroidCreatePackagePerAbi). #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Dec 3, 2024

Note this PR is against the release/9.0.1xx branch.

The MSBuild property $(AndroidCreatePackagePerAbi) is likely not used much anymore due to Google Play and Amazon stores both moving to the .aab format. Removing it in .NET 10 will allow us to simplify our BuildApk MSBuild code.

Add a deprecation warning to .NET 9 for $(AndroidCreatePackagePerAbi) to inform users that it will be removed in .NET 10.

The workaround is to use the -r specifier when calling dotnet build if you still need to create individual .apk files per ABI:

dotnet build -c Release -r android-arm64
dotnet build -c Release -r android-x64

@jpobst jpobst force-pushed the deprecate-per-package branch from a39588a to 690e875 Compare December 3, 2024 23:14
@jpobst jpobst marked this pull request as ready for review December 4, 2024 01:46
@jpobst jpobst requested a review from jonpryor December 4, 2024 01:47
@jonpryor jonpryor merged commit 82c2107 into release/9.0.1xx Dec 5, 2024
58 checks passed
@jonpryor jonpryor deleted the deprecate-per-package branch December 5, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants