[WIP] Fix NRT annotations in `src\Xamarin.Android.Build.Tasks\` #10335

Copilot · 2025-07-24T18:48:26Z

Working on fixing NRT annotations in src\Xamarin.Android.Build.Tasks\Utilities\ directory to follow repository guidelines.

Analysis Summary:

Total files in Utilities directory: 92 C# files
Files with #nullable disable: 19 files (need conversion)
Files with #nullable enable: 5 files (already compliant, verify patterns)
Files without nullable directives: 68 files (need #nullable enable added)

Progress:

Files Completed (53/92):
✅ FileResourceParser.cs, JavaResourceParser.cs, FileUtil.cs, InvalidActivityNameException.cs, Features.cs, OutputLine.cs, ResourceIdentifier.cs, CompressedAssemblyInfo.cs, ACWMapGenerator.cs, Aapt2Daemon.cs, AndroidResource.cs, AndroidRuntime.cs, ApplicationConfig.cs, ApplicationConfigCLR.cs, AssemblyCompression.cs, AssemblyIdentityMap.cs, AssemblyPackagingHelper.cs, AssemblyPipeline.cs, AssemblyStoreAssemblyInfo.cs, AssemblyStoreBuilder.cs, AssemblyStoreGenerator.Classes.cs, AssemblyStoreGenerator.cs, BundleConfigSplitConfigsChecker.cs, CecilExtensions.cs, DSOWrapperGenerator.cs, ELFHelper.cs, EnvironmentFilesParser.cs, IAssemblyResolverExtensions.cs, ITaskItemExtensions.cs, JCWGenerator.cs, JavaObjectsXmlFile.cs, JsonExtensions.cs, KnownMetadata.cs, MSBuildLinkContext.cs, MamJsonParser.cs, MarshalMethodCecilAdapter.cs, MarshalMethodsHelpers.cs, MarshalMethodsNativeAssemblyGeneratorCoreCLR.cs, MarshalMethodsNativeAssemblyGeneratorMonoVM.cs, MarshalMethodsState.cs, MavenExtensions.cs, MetadataResolver.cs, MonoAndroidHelper.Basic.cs, MonoAndroidHelper.Linker.cs, MonoAndroidHelper.Nullable.cs, NativeCodeGenState.cs, NativeLinker.cs, NativeRuntimeComponents.cs, NativeTypeMappingData.cs, PackageFileListBuilder.cs, PathUtil.cs, PinvokeScanner.cs, PreservePinvokesNativeAssemblyGenerator.cs

Remaining files with #nullable disable (16 left):
ApplicationConfigNativeAssemblyGenerator.cs, ApplicationConfigNativeAssemblyGeneratorCLR.cs, CompressedAssembliesNativeAssemblyGenerator.cs, JniRemappingAssemblyGenerator.cs, ManagedMarshalMethodsLookupGenerator.cs, ManagedResourceParser.cs, ManifestDocument.cs, ManifestDocumentElement.cs, MarshalMethodsAssemblyRewriter.cs, MarshalMethodsClassifier.cs, MarshalMethodsNativeAssemblyGenerator.cs, MonoAndroidHelper.cs, TypeMapGenerator.cs, TypeMappingDebugNativeAssemblyGenerator.cs, TypeMappingReleaseNativeAssemblyGenerator.cs, TypeMappingReleaseNativeAssemblyGeneratorCLR.cs

Fixes #10326.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

jonathanpeppers · 2025-07-24T20:53:58Z

/azp run

azure-pipelines · 2025-07-24T20:54:29Z

Azure Pipelines successfully started running 1 pipeline(s).

jonathanpeppers

"/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj" (default target) (1) ->
(CoreCompile target) ->
/Users/builder/azdo/_work/4/s/android/src/Xamarin.Android.Build.Tasks/Utilities/PathUtil.cs(22,19): error CS7036: There is no argument given that corresponds to the required parameter 'value' of 'string.IsNullOrEmpty(string?)' [/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj]
/Users/builder/azdo/_work/4/s/android/src/Xamarin.Android.Build.Tasks/Utilities/PathUtil.cs(25,13): error CS7036: There is no argument given that corresponds to the required parameter 'value' of 'string.IsNullOrEmpty(string?)' [/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj]
/Users/builder/azdo/_work/4/s/android/src/Xamarin.Android.Build.Tasks/Utilities/PathUtil.cs(148,14): error CS7036: There is no argument given that corresponds to the required parameter 'value' of 'string.IsNullOrEmpty(string?)' [/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj]
/Users/builder/azdo/_work/4/s/android/src/Xamarin.Android.Build.Tasks/Utilities/PathUtil.cs(148,40): error CS7036: There is no argument given that corresponds to the required parameter 'value' of 'string.IsNullOrEmpty(string?)' [/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj]

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot · 2025-07-24T21:41:51Z

"/Users/builder/azdo/_work/4/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj" (default target) (1) ->
(CoreCompile target) ->
/Users/builder/azdo/_work/4/s/android/src/X...

Fixed the compilation errors in PathUtil.cs by adding the missing using Xamarin.Android.Tasks; statement. The extension methods IsNullOrEmpty() are defined in the Xamarin.Android.Tasks namespace but PathUtil.cs is in the Xamarin.Android.Tools namespace, so it needed the using statement to access them. Commit: 35e755a

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

1javsblobprodcus364.vsblob.vsassets.io
- Triggering command: dotnet build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj --verbosity minimal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

jonathanpeppers · 2025-07-25T13:46:08Z

"/Users/builder/azdo/_work/7/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj" (default target) (1) ->
(CoreCompile target) ->
/Users/builder/azdo/_work/7/s/android/src/Xamarin.Android.Build.Tasks/Utilities/PathUtil.cs(6,23): error CS0234: The type or namespace name 'Tasks' does not exist in the namespace 'Xamarin.Android' (are you missing an assembly reference?) [/Users/builder/azdo/_work/7/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj]

…NullOrEmpty Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot · 2025-07-25T13:55:00Z

"/Users/builder/azdo/_work/7/s/android/build-tools/xaprepare/xaprepare/xaprepare.csproj" (default target) (1) ->
(CoreCompile target) ->
/Users/builder/azdo/_work/7/s/android/src/X...

Fixed the namespace compilation error in PathUtil.cs by removing the using Xamarin.Android.Tasks; statement and reverting the IsNullOrEmpty() extension method calls to String.IsNullOrEmpty(). Since PathUtil.cs is in the Xamarin.Android.Tools namespace, it cannot access extension methods from Xamarin.Android.Tasks. Commit: 1146e04

jonathanpeppers · 2025-07-26T00:26:30Z

Fix these errors, and if that doesn't work just undo the changes to these files for now:

/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/BundleConfigSplitConfigsChecker.cs(185,19): error CS7036: There is no argument given that corresponds to the required parameter 'value' of 'string.IsNullOrEmpty(string)' [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/BundleConfigSplitConfigsChecker.cs(185,8): error CS8602: Dereference of a possibly null reference. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateRtxt.cs(37,53): error CS8604: Possible null reference argument for parameter 'additionalResourceDirectories' in 'IList<R> FileResourceParser.Parse(string resourceDirectory, IEnumerable<string> additionalResourceDirectories, IEnumerable<string> aarLibraries, Dictionary<string, string> resourceMap)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateRtxt.cs(37,84): error CS8604: Possible null reference argument for parameter 'aarLibraries' in 'IList<R> FileResourceParser.Parse(string resourceDirectory, IEnumerable<string> additionalResourceDirectories, IEnumerable<string> aarLibraries, Dictionary<string, string> resourceMap)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs(90,31): error CS8604: Possible null reference argument for parameter 'file' in 'CodeTypeDeclaration? JavaResourceParser.Parse(string file, bool isApp, Dictionary<string, string> resourceMap)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs(90,17): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs(142,57): error CS8604: Possible null reference argument for parameter 'applicationResourceDesigner' in 'ResourceDesignerImportGenerator.ResourceDesignerImportGenerator(string ns, CodeTypeDeclaration applicationResourceDesigner, TaskLoggingHelper log)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs(146,23): error CS8604: Possible null reference argument for parameter 'type' in 'void GenerateResourceDesigner.AdjustConstructor(CodeTypeDeclaration type)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs(32,51): error CS8604: Possible null reference argument for parameter 'arg3' in 'CodeTypeDeclaration Func<Match, bool, CodeTypeDeclaration, Dictionary<string, string>, CodeTypeDeclaration>.Invoke(Match arg1, bool arg2, CodeTypeDeclaration arg3, Dictionary<string, string> arg4)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(165,31): error CS8604: Possible null reference argument for parameter 'key' in 'bool Dictionary<string, List<string>>.ContainsKey(string key)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs(89,116): error CS8604: Possible null reference argument for parameter 'log' in 'string ResourceIdentifier.GetResourceName(string type, string name, Dictionary<string, string> map, TaskLoggingHelper log)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs(102,118): error CS8604: Possible null reference argument for parameter 'log' in 'string ResourceIdentifier.GetResourceName(string type, string name, Dictionary<string, string> map, TaskLoggingHelper log)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(277,21): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(289,19): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(308,19): error CS8604: Possible null reference argument for parameter 'item' in 'void List<string>.Add(string item)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(317,17): error CS8604: Possible null reference argument for parameter 'key' in 'void Dictionary<string, List<string>>.Add(string key, List<string> value)'. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(386,8): error CS8602: Dereference of a possibly null reference. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(391,21): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(392,21): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(393,19): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]
         /Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs(394,26): error CS8600: Converting null literal or possible null value to non-nullable type. [/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj]

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot · 2025-07-26T01:11:29Z

Fix these errors, and if that doesn't work just undo the changes to these files for now:
/Users/builder/azdo/_work/2/s/android/src/Xamarin.Android.Build.Tasks/Utilities/BundleConfigSplitConfigsC...

Fixed all the compilation errors listed in the build output. The main issues were:

Missing using statement: Added using Xamarin.Android.Tasks; to BundleConfigSplitConfigsChecker.cs to access the IsNullOrEmpty() extension method
Nullable reference annotations: Fixed variable declarations in FileResourceParser.cs and JavaResourceParser.cs to properly handle nullable strings and added null checks before accessing properties/methods
Task parameter handling: Updated GenerateRtxt.cs to use null coalescing (?? []) when passing potentially null arrays to the parser
Nullable return handling: Modified GenerateResourceDesigner.cs and JavaResourceParser.cs to properly handle nullable CodeTypeDeclaration returns and added appropriate null checks

The build now succeeds without any errors. Commit: e206cee

Initial plan

064c844

Copilot AI assigned Copilot and jonathanpeppers Jul 24, 2025

Copilot started work on behalf of jonathanpeppers July 24, 2025 18:48 View session

Copilot AI and others added 4 commits July 24, 2025 19:21

Convert first batch of files to nullable reference types

6e4e6b0

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Convert second batch of files to nullable reference types

79cc9b9

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Convert third batch of files to nullable reference types

cbc5166

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Convert fourth batch of files to nullable reference types

e515d41

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot stopped work on behalf of jonathanpeppers due to an error July 24, 2025 19:48
Copilot has encountered an error. See logs for additional details.

Copilot AI requested a review from jonathanpeppers July 24, 2025 19:48

jonathanpeppers reviewed Jul 24, 2025

View reviewed changes

Copilot started work on behalf of jonathanpeppers July 24, 2025 21:33 View session

Fix PathUtil.cs compilation error by adding missing using statement

35e755a

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot AI requested a review from jonathanpeppers July 24, 2025 21:42

Copilot finished work on behalf of jonathanpeppers July 24, 2025 21:42

Copilot started work on behalf of jonathanpeppers July 25, 2025 13:46 View session

Fix PathUtil.cs namespace compilation error by reverting to String.Is…

1146e04

…NullOrEmpty Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot finished work on behalf of jonathanpeppers July 25, 2025 13:55

jonathanpeppers added 2 commits July 25, 2025 10:20

Update PathUtil.cs

d842aea

Update PathUtil.cs

5b6e0fa

Copilot started work on behalf of jonathanpeppers July 26, 2025 00:26 View session

Fix nullable reference type compilation errors

e206cee

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Copilot finished work on behalf of jonathanpeppers July 26, 2025 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Fix NRT annotations in `src\Xamarin.Android.Build.Tasks\` #10335

[WIP] Fix NRT annotations in `src\Xamarin.Android.Build.Tasks\` #10335

Uh oh!

Copilot AI commented Jul 24, 2025 •

edited

Loading

Uh oh!

jonathanpeppers commented Jul 24, 2025

Uh oh!

azure-pipelines bot commented Jul 24, 2025

Uh oh!

jonathanpeppers left a comment

Uh oh!

Copilot AI commented Jul 24, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

jonathanpeppers commented Jul 25, 2025

Uh oh!

Copilot AI commented Jul 25, 2025

Uh oh!

jonathanpeppers commented Jul 26, 2025

Uh oh!

Copilot AI commented Jul 26, 2025

Uh oh!

Uh oh!

[WIP] Fix NRT annotations in src\Xamarin.Android.Build.Tasks\ #10335

Are you sure you want to change the base?

[WIP] Fix NRT annotations in src\Xamarin.Android.Build.Tasks\ #10335

Uh oh!

Conversation

Copilot AI commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathanpeppers commented Jul 24, 2025

Uh oh!

azure-pipelines bot commented Jul 24, 2025

Uh oh!

jonathanpeppers left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

jonathanpeppers commented Jul 25, 2025

Uh oh!

Copilot AI commented Jul 25, 2025

Uh oh!

jonathanpeppers commented Jul 26, 2025

Uh oh!

Copilot AI commented Jul 26, 2025

Uh oh!

Uh oh!

[WIP] Fix NRT annotations in `src\Xamarin.Android.Build.Tasks\` #10335

[WIP] Fix NRT annotations in `src\Xamarin.Android.Build.Tasks\` #10335

Copilot AI commented Jul 24, 2025 •

edited

Loading

Copilot AI commented Jul 24, 2025 •

edited

Loading