Skip to content

Remove tests/BCL-Tests directory and move NetworkChangeTest to Mono.Android-Tests #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 22, 2025

This PR removes the deprecated tests/BCL-Tests directory which contained Xamarin.Android projects that are no longer needed in the .NET 10 codebase.

Changes Made

Moved Valuable Test

  • Moved NetworkChangeTest.cs from tests/BCL-Tests/LocalTests.NUnit/System.Net/ to tests/Mono.Android-Tests/Mono.Android-Tests/System.Net.NetworkInformation/
  • Updated namespace from BclTests to System.NetTests to match existing patterns in Mono.Android-Tests
  • Added compile reference to Mono.Android.NET-Tests.csproj

Removed BCL-Tests Directory

  • Deleted entire tests/BCL-Tests directory with all contents including:
    • LocalTests.NUnit project (59 files removed)
    • Xamarin.Android.Bcl-Tests project (130+ files removed)
    • All associated resources, assets, and configuration files

Updated Solution File

  • Removed BCL-Tests solution folder from Xamarin.Android-Tests.sln
  • Removed both BCL-Tests project references
  • Moved TestRunner projects from BCL-Tests folder to Core folder for better organization

Updated CI Configuration

  • Removed BCL-Tests reference from Azure Pipeline test job determination logic in Step_DetermineAzurePipelinesTestJobs.cs

Summary

  • Files changed: 29 files
  • Net lines removed: 971 lines
  • One useful test preserved and properly integrated into the main test suite

The NetworkChangeTest.cs was the only valuable test in the BCL-Tests directory and has been successfully moved to the appropriate location with correct namespace and project references.

Fixes #10319.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…o.Android-Tests

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove tests\BCL-Tests Remove tests/BCL-Tests directory and move NetworkChangeTest to Mono.Android-Tests Jul 22, 2025
@Copilot Copilot AI requested a review from jonathanpeppers July 22, 2025 17:33
Copilot finished work on behalf of jonathanpeppers July 22, 2025 17:33
@jonathanpeppers
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonathanpeppers jonathanpeppers marked this pull request as ready for review July 22, 2025 19:33
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) July 22, 2025 19:35
@jonathanpeppers jonathanpeppers merged commit 8f5f54e into main Jul 22, 2025
59 of 60 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10319 branch July 22, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tests\BCL-Tests
2 participants