Fix NRT annotations in MSBuild Tasks Legacy/ResolveAndroidTooling.cs #10315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed nullable reference type (NRT) annotations in the MSBuild Tasks to follow repository guidelines as specified in
copilot-instructions.md
.Changes Made
During investigation, found that most MSBuild task files in
src/Xamarin.Android.Build.Tasks/Tasks/
already have proper#nullable enable
directives and correct property annotations. Only one file needed updates:Fixed
Legacy/ResolveAndroidTooling.cs
:#nullable disable
to#nullable enable
[Output]
property to be nullable:public string? TargetFrameworkVersion { get; set; }
string.IsNullOrWhiteSpace()
calls to use extension method pattern:property.IsNullOrWhiteSpace()
Verification
#nullable enable
directivepublic string? PropertyName { get; set; }
[Required] public string PropertyName { get; set; } = "";
[Output] public string? PropertyName { get; set; }
The repository's MSBuild Tasks are now fully compliant with the nullable reference types guidelines.
Fixes #10277.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.