Fix Android workload detection issue on Linux builds #10216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished work on behalf of
jonathanpeppers
June 17, 2025 17:06
|
@copilot summarize the changes here, do not make any changes. |
Copilot stopped work on behalf of
jonathanpeppers due to an error
June 17, 2025 17:30
|
@copilot summarize the changes here, do not make any changes. |
Summary of ChangesThe changes address an Android workload detection issue on Linux builds by modifying the condition logic in Before (original logic):
After (fixed logic):
Key changes:
This allows Linux local builds to use the full extends array while preserving the AOT-exclusion behavior only for GitHub Actions CI builds where AOT components can fail to install. Commit: 86b940e |
jonathanpeppers
approved these changes
Jun 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Android workload detection was failing on Linux during local builds, causing the error:
Root Cause
The issue was in
build-tools/create-packs/ConfigureLocalWorkload.targetswhere the Linux-specific workload configuration was using only"microsoft-net-runtime-android"as the extends element, while non-Linux platforms were dynamically extracting the full extends array from the WorkloadManifest.json file.The full extends array includes additional required dependencies:
"microsoft-net-runtime-android-net9""microsoft-net-runtime-android"Solution
Updated the Linux-specific
AndroidWorkloadExtendsElementto include the necessary non-AOT runtime dependencies while maintaining the existing logic that excludes AOT components that don't work reliably on Linux.Testing
Verified that:
./dotnet-local.sh new androidcreates projects successfullyandroidworkload is resolvedNote: After this fix, there may be separate dependency resolution issues (e.g., wasm-tools) that appear, but the primary Android workload detection issue has been resolved.
Fixes #10215.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.