-
Notifications
You must be signed in to change notification settings - Fork 555
Remove unused CilStrip MSBuild task and related references #10206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Xamarin.Android.Tasks.CilStrip
Copilot finished work on behalf of
jonathanpeppers
June 16, 2025 17:06
src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
Copilot stopped work on behalf of
jonathanpeppers due to an error
June 16, 2025 17:39
jonathanpeppers
added a commit
that referenced
this pull request
Jun 16, 2025
Context: #10206 @copilot found these in #10206, so I checked their usage one-by-one to remove completely unused code. Many of these look *very* old, like `<GetConvertedJavaLibraries/>` for example, mentions an old Android tool named `jack`. Removing the `<UsingTask>` declarations should also slightly improve MSBuild evaluation time. From what I've seen profiling in the past, MSBuild creates a full path string for each `AssemblyFile` entry.
…line Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
jonathanpeppers
approved these changes
Jun 16, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Jun 16, 2025
Context: #10206 @copilot found these in #10206, so I checked their usage one-by-one to remove completely unused code. Many of these look *very* old, like `<GetConvertedJavaLibraries/>` for example, mentions an old Android tool named `jack`. Removing the `<UsingTask>` declarations should also slightly improve MSBuild evaluation time. From what I've seen profiling in the past, MSBuild creates a full path string for each `AssemblyFile` entry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Xamarin.Android.Tasks.CilStrip
MSBuild task was identified as vestigial code from Xamarin.Android that is no longer used anywhere in the build system. This PR removes all references to it.Changes Made
CilStrip.cs
: Removed the entire 122-line source file containing the unused MSBuild taskXamarin.Android.Common.targets
Resources.Designer.cs
Additional Findings
During the analysis, 16 other MSBuild tasks were identified as having UsingTask declarations but not being used in any targets:
Note: XA3002 ("Invalid AOT mode") was preserved as it is actively used by
Aot.cs
andGetAotAssemblies.cs
tasks.Verification
./build.sh --target=BuildMSBuildTasksOnly
Fixes #10205.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.