Skip to content

[build] set %(Kind) for PushManifestToBuildAssetRegistry #10088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

jonathanpeppers
Copy link
Member

Context: https://github.com/dotnet/arcade/blob/79ecdf3ef50e5e8e9d2b02e7113ec37c4219eeb5/src/Microsoft.DotNet.Build.Manifest/BuildModelFactory.cs#L95

Builds on main/release branches fail with:

build-tools\create-packs\Directory.Build.targets(175,5): error : Missing 'Kind' property on artifact D:\a\_work\1\a\nuget-signed\Microsoft.Android.Ref.36.36.0.0-ci.main.72.nupkg.
Possible values are 'Blob', 'PDB', 'Package'.

Set %(Kind)=Package for .nupkg files and %(Kind)=Blob for everything else.

Context: https://github.com/dotnet/arcade/blob/79ecdf3ef50e5e8e9d2b02e7113ec37c4219eeb5/src/Microsoft.DotNet.Build.Manifest/BuildModelFactory.cs#L95

Builds on main/release branches fail with:

    build-tools\create-packs\Directory.Build.targets(175,5): error : Missing 'Kind' property on artifact D:\a\_work\1\a\nuget-signed\Microsoft.Android.Ref.36.36.0.0-ci.main.72.nupkg.
    Possible values are 'Blob', 'PDB', 'Package'.

Set `%(Kind)=Package` for `.nupkg` files and `%(Kind)=Blob` for
everything else.
@jonathanpeppers
Copy link
Member Author

@jonathanpeppers jonathanpeppers marked this pull request as ready for review April 29, 2025 02:16
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) April 29, 2025 02:17
@jonathanpeppers jonathanpeppers merged commit 4eafe66 into main Apr 29, 2025
122 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/fix-bar branch April 29, 2025 02:45
jonathanpeppers added a commit that referenced this pull request Apr 29, 2025
Context: https://github.com/dotnet/arcade/blob/79ecdf3ef50e5e8e9d2b02e7113ec37c4219eeb5/src/Microsoft.DotNet.Build.Manifest/BuildModelFactory.cs#L95

Builds on main/release branches fail with:

    build-tools\create-packs\Directory.Build.targets(175,5): error : Missing 'Kind' property on artifact D:\a\_work\1\a\nuget-signed\Microsoft.Android.Ref.36.36.0.0-ci.main.72.nupkg.
    Possible values are 'Blob', 'PDB', 'Package'.

In f2eea99, we updated `Microsoft.DotNet.Build.Tasks.Feed`
which seems to have caused this issue:

* Microsoft.DotNet.Build.Tasks.Feed: from 9.0.0-beta.24408.2 to 10.0.0-beta.25223.119

To fix this, set `%(Kind)=Package` for `.nupkg` files and `%(Kind)=Blob` for
everything else.
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants