Skip to content

[xaprepare] Fix warnings produced by building and running. #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

[xaprepare] Fix warnings produced by building and running. #10048

merged 1 commit into from
Apr 17, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 16, 2025 •
edited
Loading

Fix warnings produced by building and running xaprepare:

warning NU1510: PackageReference System.Net.Http will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
warning NU1510: PackageReference System.Private.Uri will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
warning NU1510: PackageReference System.Text.Encoding.CodePages will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.

EXEC : warning : Using cached installation script found in 'C:\Users\user\android-archives\dotnet-install.ps1'
  • Remove referenced packages, these were likely required when xaprepare was multi-targeting with net472
  • Convert cached script warning to a debug message, as this is expected behavior

@jpobst jpobst marked this pull request as ready for review April 17, 2025 17:58
@jpobst jpobst requested a review from grendello as a code owner April 17, 2025 17:58
jonathanpeppers
jonathanpeppers approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the NuGet pruning warnings in another PR, so nice to merge this one first.

@jonathanpeppers jonathanpeppers merged commit da830e8 into main Apr 17, 2025
57 of 59 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/jpobst/xaprepare-warnings branch April 17, 2025 18:01
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@grendello grendello Awaiting requested review from grendello grendello is a code owner

@pjcollins pjcollins Awaiting requested review from pjcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpobst @jonathanpeppers