[build] install .NET 10.x for BAR manifest #10040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Publish symbols and Push to Maestro` job and `generate and
publish BAR manifest` step fail with:
C:\hostedtoolcache\windows\dotnet\sdk\9.0.203\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(166,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 10.0. Either target .NET 9.0 or lower, or use a version of the .NET SDK that supports .NET 10.0. Download the .NET SDK from https://aka.ms/dotnet/download [D:\a\_work\1\s\build-tools\create-packs\Microsoft.Android.Sdk.proj]
0 Warning(s)
1 Error(s)
It looks like we were using .NET 9 previews in the past:
- task: UseDotNet@2
displayName: Install .NET 9.x
inputs:
version: 9.x
includePreviewVersions: true
So, we can use .NET 10 previews for this during .NET 10 development.
|
Looks like it works:
|
pjcollins
reviewed
Apr 16, 2025
| inputs: | ||
| version: 9.x | ||
| version: 10.x |
There was a problem hiding this comment.
Similar to how we declare DotNetTargetFramework and DotNetStableTargetFramework in the variables template, maybe we should do something similar for DotNetSdkVersion to avoid needing to bump this again separately at some point in the future?
https://github.com/dotnet/android/blob/main/build-tools/automation/yaml-templates/variables.yaml#L26
Good with this as is to unblock things though
There was a problem hiding this comment.
I'll switch to use a variable here:
There is a similar spot.
pjcollins
approved these changes
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Publish symbols and Push to Maestrojob andgenerate and publish BAR manifeststep fail with:It looks like we were using .NET 9 previews in the past:
So, we can use .NET 10 previews for this during .NET 10 development.