Make the NativeAOT debugger script more flexible #10016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
reviewed
Apr 9, 2025
Make it able to detect the OS-specific path to the NDK toolchain binaries, as well as the path to the NDK root directory using a number of environment variables used at one time or another for this purpose. Instead of hard-coding path to the `lldb-server` binary, which is located in a versioned directory, use `clang` itself to print full path to the binary, thus making the script LLVM version agnostic.
1ac5132 to
ff25bd5
Compare
dellis1972
approved these changes
Apr 9, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it able to detect the OS-specific path to the NDK toolchain binaries,
as well as the path to the NDK root directory using a number of environment
variables used at one time or another for this purpose.
Instead of hard-coding path to the
lldb-serverbinary, which is located ina versioned directory, use
clangitself to print full path to the binary,thus making the script LLVM version agnostic.
Additionally, detect the attached device's architecture and use the correct
lldb-serverbinary.