[XABT] Remove support for $(_AndroidGenerateNativeAssembly) = false (typemaps).
#10001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31500f9 to
7a3831b
Compare
grendello
approved these changes
Apr 3, 2025
dellis1972
approved these changes
Apr 3, 2025
jonathanpeppers
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #9292
In #9292, we removed support for the "instant run" feature. This feature required the use of typemaps that existed outside of the "native" assemblies (
$(_AndroidGenerateNativeAssembly)=false). This support is no longer needed, and in fact causes a build error if it is used:As such, clean up our codebase to remove support for this.
Additionally, unused fields in the
Module[Debug|Release]DataandTypeMap[Debug|Release]Entrydata classes were removed to help make it clearer what data is required to generate typemaps.