Suppress spurious CodeQL warning related to DefaultAzureCredential #3503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suppressed use of DefaultAzureCredential.
There was a problem hiding this comment.
Pull Request Overview
This PR suppresses a CodeQL security warning related to the use of DefaultAzureCredential in the ActiveDirectoryAuthenticationProvider class. The change adds a comment explaining that this is library code and applications are responsible for using more secure credential options.
- Adds a CodeQL suppression comment with justification for DefaultAzureCredential usage
- Clarifies that the library provides a default implementation while applications should use more secure alternatives
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
mdaigle
previously approved these changes
Jul 22, 2025
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
+ Coverage 64.78% 69.82% +5.04%
==========================================
Files 276 276
Lines 62192 62192
==========================================
+ Hits 40289 43424 +3135
+ Misses 21903 18768 -3135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Suppressed use of DefaultAzureCredential.
apoorvdeshmukh
approved these changes
Jul 23, 2025
cheenamalhotra
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppressed CodeQL warning related to our use of DefaultAzureCredential.