Merge | DbConnectionString #3416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the DbConnectionString class into the common project and renames it from DBConnectionString to follow naming conventions, updating all consumers accordingly.
- Renamed and relocated
DBConnectionStringtoDbConnectionStringunderCommon - Updated
SqlClientPermissionto reference the renamed class - Adjusted the .csproj to include the new file and remove the old compile entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SqlClientPermission.netfx.cs | Switched from DBConnectionString to DbConnectionString usage |
| DbConnectionString.netfx.cs | Renamed class and replaced KEY constants with DbConnectionStringKeywords and synonyms |
| netfx/src/Microsoft.Data.SqlClient.csproj | Added compile include for DbConnectionString.netfx.cs, removed DBConnectionString.cs |
Comments suppressed due to low confidence (2)
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj:951
- Verify the surrounding
<ItemGroup>tags after removing this closing tag and the next<ItemGroup>to ensure the XML structure remains valid and all<Compile>entries are grouped correctly.
</ItemGroup>
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlClientPermission.netfx.cs:65
- [nitpick] Consider adding or updating unit tests around permission entries that use
DbConnectionStringto ensure behavior hasn’t regressed after the rename.
AddPermissionEntry(new DbConnectionString(constr));
...rosoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionString.netfx.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=========================================
+ Coverage 0 92.58% +92.58%
=========================================
Files 0 6 +6
Lines 0 310 +310
=========================================
+ Hits 0 287 +287
- Misses 0 23 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
approved these changes
Jun 16, 2025
mdaigle
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge PR is pretty simple. It moves the DbConnectionString class from the netfx project into the common project. It was originally named DBConnectionString but is now renamed to DbConnectionString to follow naming conventions (after @paulmedynski caused a bunch of merge conflicts fixing broken link to the old name...)
I developed this PR on top of some cleanup work for DbConnectionOptions that I rebased off of. There may be some remnants of those changes in this PR.
Issues
Continues work on #1261
Testing
Class is just being renamed and moved, project still builds, CI should be good to verify.