Merge | SessionHandle, TdsParserStateObject #3341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mdaigle
approved these changes
May 12, 2025
benrr101
approved these changes
May 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
==========================================
- Coverage 65.07% 58.67% -6.40%
==========================================
Files 298 293 -5
Lines 65515 65059 -456
==========================================
- Hits 42634 38176 -4458
- Misses 22881 26883 +4002
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to merge TdsParserStateObject. I've broken this down commit-by-commit for simplicity, but there are three changes here:
Contributes to #1261.
SessionHandle has a parallel in PacketHandle. This is treated as an alias of IntPtr in netfx, and a type in its own right in netcore. Dealing with this will probably need a PR in its own right, and it'll unblock a number of methods which are identical but which deal with PacketHandles.