Skip to content

Generic Math.md: Refactor onto single type hierarchy. #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Generic Math.md: Refactor onto single type hierarchy. #2462

wants to merge 12 commits into from
+164 −180

Conversation

otac0n
Copy link
Contributor

@otac0n otac0n commented May 31, 2025 •
edited
Loading

Batch of updates to the Generic Math.md proposal as discussed in chat.

Summary of the PR

  • During the implementation, I found the integer version of Matrix.Lerp could not be reasonably implemented.
  • Extension methods should be used for the public API per the chat.
  • The types can be unified by eliminating the properties and bitwise operators.

Related issues, Discord discussions, or proposals

https://discord.com/channels/521092042781229087/587346162802229298/1378782513010577449 and prior

Further Comments

Partially implemented in #2459

@otac0n
Generic Math.md
c15afd9 
Restrict lerp function to F matrices.
@otac0n otac0n requested a review from a team as a code owner May 31, 2025 21:06
@Perksey
Copy link
Member

Perksey commented Jun 7, 2025 •
edited
Loading

It's probably worth clarifying at line 23 what our intention is i.e. using one type with extension APIs (and replacing all usages of VectorNF/VectorNI with VectorND as necessary)

@otac0n otac0n changed the title Generic Math.md: Restrict lerp function to F matrices. Generic Math.md: Refactor onto single type hierarchy. Jul 16, 2025
Perksey
Perksey reviewed Jul 23, 2025
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments

documentation/proposals/Proposal - Generic Math.md Outdated
- INumberBase<>.MinMagnitude, (Memberwise, Memberwise)
- INumberBase<>.MinMagnitudeNumber, (Memberwise, Memberwise)
- ~~INumberBase<>.MultiplyAddEstimate, (Memberwise, Memberwise, Memberwise)~~
- DOTNET>=9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's assume this, it seems like .NET 10 will be latest LTS by the time we ship anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Silk.NET Development Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otac0n @Perksey