Skip to content

fix: better generic support in document array stack #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 20, 2023
Merged

fix: better generic support in document array stack #1147

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ea97d59
refactor: create io mixin
samsja Feb 17, 2023
3d2e656
fix: fix mypy
samsja Feb 17, 2023
cb30f82
refactor: move array and array stacked to subfolder
samsja Feb 17, 2023
27bbbd1
refactor: move document array io to mixin
samsja Feb 17, 2023
5e324cf
refactor: create io mixin for docuemnt array
samsja Feb 17, 2023
c3482b8
fix: fix sized problem
samsja Feb 17, 2023
990f4ff
fix: make any array generic for type var
samsja Feb 17, 2023
57b2101
fix : allow string
samsja Feb 17, 2023
0bded51
feat: add generic to document array stacked
samsja Feb 17, 2023
4a477f4
fix: fix generic class getitem
samsja Feb 17, 2023
d07ccd0
fix: ad comment
samsja Feb 17, 2023
fc3967b
Merge branch 'feat-rewrite-v2' into fix-generic
samsja Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix sized problem 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
  • Loading branch information
@samsja
samsja committed Feb 17, 2023
commit c3482b8538eada9c8b9c152067d792e5bba1a37e
7 changes: 5 additions & 2 deletions docarray/array/array/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
Generator,
Iterable,
Optional,
Sized,
Tuple,
Type,
TypeVar,
Expand Down Expand Up @@ -81,10 +80,14 @@ def __getitem__(self, item: slice):
return self.content[item]


class IOMixinArray(Iterable[BaseDocument], Sized):
class IOMixinArray(Iterable[BaseDocument]):

document_type: Type[BaseDocument]

@abstractmethod
def __len__(self):
...

@abstractmethod
def __init__(
self,
Expand Down