Fixed #36499 -- Adjusted utils_tests.test_html.TestUtilsHtml.test_strip_tags following Python's HTMLParser new behavior. #19639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliff688
reviewed
Jul 14, 2025
|
There is one more failure in |
Yeah, I started fixing this test yesterday, and I've been trying to think what the right fix is, because is not straightforward. Before, this line: self.assertHTMLEqual("< div></ div>", "<div></div>")would raise an AssertionError with message: Now it fails with: I need to dig deeper to understand if the assertion message change is acceptable or not. |
cliff688
reviewed
Jul 16, 2025
be4c92c to
9cb945b
Compare
cliff688
approved these changes
Jul 22, 2025
…ython's HTMLParser fixed parsing. Further details about Python changes can be found in: python/cpython@0243f97. Thank you Clifford Gama for the thorough review!
…ip_tags following Python's HTMLParser new behavior. Python fixed a quadratic complexity processing for HTMLParser in: python/cpython@6eb6c5d.
Thank you, I fixed the commit 🎯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛑 Not to be merged before 3.13.6, 3.12.12, 3.11.14, 3.10.19 and 3.9.24 are released (and Jenkins CI gets updated).
Trac ticket number
ticket-36499
Branch description
As described in the ticket, Python's HTMLParser was adjusted to avoid poor performance on malformed HTML. This branch adjust the Django tests that were specifically added for performance related reports to follow Python's HTMLParser behavior.
Checklist
mainbranch.