UX: hashtag alignment in text and autocomplete #33902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

chapoi merged 4 commits into main from hashtag-alignment

Jul 29, 2025

+20 −50

Contributor

chapoi commented Jul 28, 2025 •

edited

Loading

We have to revert the mention mixin back from inline-flex to inline-block, due it also being used within text, and without inline-block, the alignment with text is impossible to get right.

Other than that this commit also:

replaced some of the spacing units with the new vars
removed unused hashtag css (replaced by hashtag-raw and hashtag-cooked)
streamlines sizing to using .93em everywhere and making sure elements don't get a double dose sizing by also applying font-down-1
try to simplify the logic between icon-square-emoji

This should look like:

Hashtag autocomplete

CleanShot 2025-07-29 at 16 07 36@2x

Hashtag cooked

CleanShot 2025-07-29 at 16 08 27@2x

chapoi added 4 commits

July 28, 2025 17:10


          UX: hashtag alignment in text and autocomplete

dc4dfec


          simplify ac alignment

ec16438


          Change mentions back to inline-block

a5615f3


          remove legacy hashtag css

fea5d34

chapoi marked this pull request as ready for review

July 29, 2025 14:08

dbattersby approved these changes

View reviewed changes

Contributor

dbattersby left a comment

I love it, tested it out locally and it looks great 😍

chapoi merged commit d791e60 into main

17 checks passed

chapoi deleted the hashtag-alignment branch

July 29, 2025 16:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet